feat(google-maps): Refactored options and added feature to update the map options#1618
feat(google-maps): Refactored options and added feature to update the map options#1618AE1NS wants to merge 1 commit intoionic-team:mainfrom AE1NS:options-refactoring
Conversation
|
I also fixed an issue with the padding values in Android, that were used as DP value. I used the |
| CAP_PLUGIN_METHOD(disableClustering, CAPPluginReturnPromise); | ||
| CAP_PLUGIN_METHOD(destroy, CAPPluginReturnPromise); | ||
| CAP_PLUGIN_METHOD(setCamera, CAPPluginReturnPromise); | ||
| CAP_PLUGIN_METHOD(getMapType, CAPPluginReturnPromise); |
There was a problem hiding this comment.
This is a breaking change - these should be kept, perhaps marked as deprecated.
There was a problem hiding this comment.
ac75252#diff-e887271a6e743973df748b0b83f29f5250ad28c088c82e1aacadfbb4ffc3d1b4R460
The method still exists in the map.ts with the same return type and is marked as deprecetd there. It was just removed from the native implementations because its replaced by the new solution.
There was a problem hiding this comment.
Are you still waiting for an update here or is it 'solved' with my comment? I just want to make sure that I am not the reason why this is on hold.
3 participants
This refactorings simplify the map options handling and therefore remove many methods, that can now be set in the instantiation of the map but also be updated with a new method.
Closes #1617